-
-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Next.js 13 RSC integration #149
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I tried that and it causes the same error. Looks like next is no longer accepting this syntax. If you go trough the docs their propose (https://nextjs.org/docs/messages/app-dir-dynamic-href ) they recommend exactly the opposite. |
@Morishiri Can you share a reproduction? In this branch, we have both an app example with this syntax as well as an extensive unit test suite for the navigation APIs. Both use My guess would be that either the wrong |
@amannn Found the issue! I had the When I landed on
I changed it to
and it works now. Thanks for the pointer! |
Hey, I'm using Next 14.0.1, I updated next-intl from rc-6 to rc-10 and now I'm getting this error:
the other time:
It doesn't happen immediately, it seems that it happens when there's a compilation error, and then you fix it. Do you have any idea how to fix this error? EDIT, it's been happening on rc-6 as well |
@Tomekmularczyk Can you share a reproduction? (template) Please also check the relevant troubleshooting section in the docs. |
@Tomekmularczyk Can you also check the following:
|
Hi, the directory structure is pretty much the same: I tried deleting node_modules, .next and installing everything again.
It kind of seems that when /[locale]/[...rest]/page is compiled then it happens. Could be unrelated. I cannot reproduce it on fresh repo. |
Actually, it's been happening on rc-6 for me, I just did not notice it... |
Maybe this section from the docs is relevant for you: Pathnames without a locale prefix. If you find that the issue is caused by |
Thank you SO MUCH to everyone who has participated in this crazy pull request. Felt almost surreal to finally push that big, green merge button after a year of exploration and iteration on this topic. All the feedback, code contributions, and testing from everyone who collaborated on this pull request made all the difference on what ended up as the RSC integration of If you find something that hasn't been covered so far, please open a new discussion or issue! See also: |
→ Please refer to the announcement
Fixes #488
Fixes #402
Fixes #578